Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): update aps-analytics to aar #11444

Merged
merged 2 commits into from Feb 11, 2020
Merged

chore(android): update aps-analytics to aar #11444

merged 2 commits into from Feb 11, 2020

Conversation

garymathews
Copy link
Contributor

  • Update aps-analytics.jar to aps-analytics.aar
  • Utilize AndroidX support library

TIMOB-27737

@build build added this to the 9.0.0 milestone Jan 23, 2020
@build
Copy link
Contributor

build commented Jan 23, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6551 tests are passing.
(There are 701 skipped tests not included in that total)

Generated by 🚫 dangerJS against b2e7524

sgtcoolguy
sgtcoolguy approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it'd be good for @jquick-axway to double-check

jquick-axway
jquick-axway approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

(Thanks Gary!)

@garymathews
Copy link
Contributor Author

@jquick-axway Seems we can't just drop *.aar into titanium/lib folder. It wants *.jar.

@garymathews garymathews force-pushed the TIMOB-27737 branch 2 times, most recently from b24b867 to 7a53a84 Compare February 10, 2020 23:02
@lokeshchdhry lokeshchdhry merged commit 8181dc5 into tidev:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @sgtcoolguy @jquick-axway @lokeshchdhry