Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extend get/set property method removal from 9.0.0 to 10.0.0 #11455

Merged
merged 1 commit into from Feb 6, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27740


Test:

  1. Build and run the below code on Android.
  2. In the log, verify you see 4 deprecation warnings stating these APIs will be removed in Titanium 10.0.0, not 9.0.0.
  3. Build and run on iOS.
  4. In the log, verify you see 4 deprecation warnings stating these APIs will be removed in Titanium 10.0.0, not 9.0.0.

Android log output...

[WARN]  Proxy: Automatic setter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 10.0.0. Please modify the property in standard JS style: obj.text = value; or obj['text'] = value;
[WARN]  Proxy: Automatic getter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 10.0.0. Please access the property in standard JS style: obj.text; or obj['text'];
[WARN]  AppModule: Automatic getter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 10.0.0. Please access the property in standard JS style: obj.proximityDetection; or obj['proximityDetection'];
[WARN]  AppModule: Automatic setter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 10.0.0. Please modify the property in standard JS style: obj.proximityDetection = value; or obj['proximityDetection'] = value;

iOS log output...

[WARN]  Automatic setter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 10.0.0. Please modify the property in standard JS style: obj.text = value; or obj['text'] = value;
[WARN]  Automatic getter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 10.0.0. Please access the property in standard JS style: obj.text or obj['text']
[WARN]  Automatic getter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 10.0.0. Please access the property in standard JS style: obj.proximityDetection or obj['proximityDetection']
[WARN]  Automatic setter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 10.0.0. Please modify the property in standard JS style: obj.proximityDetection = value; or obj['proximityDetection'] = value;

app.js

var window = Ti.UI.createWindow();
var label = Ti.UI.createLabel();
label.setText("Hello World");  // <- Deprecated
label.getText();  // <- Deprecated
window.add(label);
window.open();

Ti.App.getProximityDetection();  // <- Deprecated
Ti.App.setProximityDetection(false);  // <- Deprecated

@build
Copy link
Contributor

build commented Jan 28, 2020

Warnings
⚠️

Commit acc1761a3cc517e84f6d65d9aa30820ee466d56f has a message "TiAPI: extend get/set property method removal to 10.0.0" giving 2 errors:

  • type must be lower-case
  • type must be one of [build, chore, ci, docs, feat, fix, improvement, perf, refactor, revert, style, test]
Messages
📖

💾 Here's the generated SDK zipfile.

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖

✅ All tests are passing
Nice one! All 6549 tests are passing.
(There are 701 skipped tests not included in that total)

Generated by 🚫 dangerJS against acc1761

@jquick-axway jquick-axway changed the title TiAPI: extend get/set property method removal from 9.0.0 to 10.0.0 chore: extend get/set property method removal from 9.0.0 to 10.0.0 Jan 28, 2020
@garymathews
Copy link
Contributor

Do we want to include the changes from #11049 ?

@jquick-axway
Copy link
Contributor Author

I'm open to additional changes.

Personally, I'd like to see use log the JS file name and line number.

@sgtcoolguy sgtcoolguy merged commit 04b3a63 into tidev:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants