fix(android): strip xmlns definitions from child elements in AndroidManifest.xml #11462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TIMOB-27746: Apps built with 9.0.0 can't be uploaded to Firebase App Distribution when including certain modules. * Caused by "android-manifest.js" code's copyFromAndroidManfiest() function. * Node "xmldom" parser was wrongly injecting namespaces into chlid elements when doing a cloneNode() or importNode(). * This is a bug in "xmldom" module. Worked-around it by stripping out namespace declarations via toString() function.
Tests:
|
garymathews
reviewed
Feb 4, 2020
jquick-axway
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27746
Note:
The damage has already been done to the 9.0.0 built modules "ti.map" and "ti.playservices" since this issue is already in their "AndroidManfiest.xml" files packaged within their AARs. We will need to rebuild the ticket's listed modules after merging this PR.