Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): skip compiled plist lookup for watchOS framework compatibility #11469

Merged
merged 1 commit into from Feb 10, 2020
Merged

fix(ios): skip compiled plist lookup for watchOS framework compatibility #11469

merged 1 commit into from Feb 10, 2020

Conversation

hansemannn
Copy link
Collaborator

cb1kenobi
cb1kenobi approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. We've never seen an example with an extension with a framework, so I can see the problem. APPROVED!

@build build added this to the 9.0.0 milestone Feb 10, 2020
@build
Copy link
Contributor

build commented Feb 10, 2020

Messages
📖

💾 Here's the generated SDK zipfile.
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6550 tests are passing.
(There are 701 skipped tests not included in that total)

Generated by 🚫 dangerJS against e6de446

@cb1kenobi cb1kenobi merged commit 58be7ac into tidev:master Feb 10, 2020
@hansemannn hansemannn deleted the TIMOB-27756 branch February 10, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
community 🔥 in-qe-testing 🕵
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @build @cb1kenobi