Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android)(9_0_X): module builds should fail with aar in lib folder in 9.0.0 #11474

Merged
merged 2 commits into from Feb 12, 2020
Merged

feat(android)(9_0_X): module builds should fail with aar in lib folder in 9.0.0 #11474

merged 2 commits into from Feb 12, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway
feat(android): module builds should fail with aar in lib folder
8fb5c1e 
- Breaking change as of Titanium 9.0.0
- Gradle build system won't merge AAR library into build AAR. So, while it compiles, the built AAR is missing classes the app needs to function.
@jquick-axway
chore(android): use constant for kotlin jvmTarget in module template
d47d353
@jquick-axway jquick-axway added this to the 9.0.0 milestone Feb 12, 2020
@build
Copy link
Contributor

build commented Feb 12, 2020

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6555 tests are passing.
(There are 703 skipped tests not included in that total)

Generated by 🚫 dangerJS against d47d353

@lokeshchdhry
Copy link
Contributor

FR Passed.

Having an .aar file in the libs folder errors with :
ERROR] [GRADLE] > AAR files are no longer supported under the "lib" directory. You must reference AAR libraries via a "build.gradle" file's dependencies section instead

Studio Ver: 6.0.0.201911251516
SDK Ver: 9.0.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.3.1
Appc NPM: 4.2.15
Appc CLI: 7.1.2
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.4
Node Ver: 12.13.1
NPM Ver: 6.12.1
Java Ver: 11.0.1
Android Emu: ⇨ google Pixel (Android 10)

@lokeshchdhry lokeshchdhry merged commit c8bbeab into tidev:9_0_X Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android BREAKING CHANGES ⚠️ improvement no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jquick-axway @build @lokeshchdhry