Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): add search bar token API #11489

Merged
merged 11 commits into from Mar 16, 2020
Merged

feat(ios): add search bar token API #11489

merged 11 commits into from Mar 16, 2020

Conversation

hansemannn
Copy link
Collaborator

@build build added this to the 9.1.0 milestone Feb 20, 2020
@build build requested review from a team February 20, 2020 20:50
@build
Copy link
Contributor

build commented Feb 20, 2020 •
edited

Warnings
⚠️

Commit b6e8f3906274ddb05dedafd638aab5cd06d2e498 has a message "fixed linting issue" giving 2 errors:

  • subject may not be empty
  • type may not be empty
Messages
📖

💾 Here's the generated SDK zipfile.
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖

✅ All tests are passing
Nice one! All 6625 tests are passing.
(There are 699 skipped tests not included in that total)

Generated by 🚫 dangerJS against cb52c54

@hansemannn hansemannn changed the title feat: add search bar token API feat(ios): add search bar token API Feb 20, 2020
vijaysingh-axway
vijaysingh-axway suggested changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansemannn Please address review comments. Thanks!

iphone/Classes/TiUISearchBarProxy.m Show resolved Hide resolved
iphone/Classes/TiUISearchBarProxy.m Show resolved Hide resolved
apidoc/Titanium/UI/SearchBar.yml Outdated Show resolved Hide resolved
iphone/Classes/TiUISearchBarProxy.m Show resolved Hide resolved
vijaysingh-axway
vijaysingh-axway approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@ssaddique
Copy link
Contributor

FR Passed

Test Environment

Studio Ver: 5.1.4.201909061933
SDK Ver: 9.1.0 (this PR)
OS Ver: 10.14.6
Xcode Ver: Xcode 11.3.1
Appc CLI: 7.1.2
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.4
Node Ver: 10.17.0
Emulator: All iOS 13 simulators.

Tested with < iOS 13 simulators, no crashes or anything unexpected.

@ssaddique ssaddique merged commit 0680dcd into tidev:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
community 🔥 docs in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @build @ssaddique @vijaysingh-axway