Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): use searchtextfield exposed in iOS 13 to set color #11494

Merged
merged 8 commits into from Mar 20, 2020
Merged

fix(ios): use searchtextfield exposed in iOS 13 to set color #11494

merged 8 commits into from Mar 20, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.1.0 milestone Feb 21, 2020
@build build requested a review from a team February 21, 2020 23:54
@build
Copy link
Contributor

build commented Feb 21, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6626 tests are passing.
(There are 699 skipped tests not included in that total)

Generated by 🚫 dangerJS against 38cb2ab

janvennemann
janvennemann requested changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some notes about code formatting. Please use property accessor where possible ;)

iphone/Classes/TiUISearchBar.m Outdated Show resolved Hide resolved
iphone/Classes/TiUISearchBar.m Outdated Show resolved Hide resolved
iphone/Classes/TiUISearchBar.m Outdated Show resolved Hide resolved
iphone/Classes/TiUISearchBar.m Outdated Show resolved Hide resolved
@vijaysingh-axway
Copy link
Contributor Author

@janvennemann Updated!

@nguyen8427
Copy link

hello, is it possible to put this fixed in 8.3 or 8.4 release?

@ssaddique
Copy link
Contributor

ssaddique commented Mar 18, 2020 •
edited

FR failed. See JIRA ticket for details.

@ssaddique
Copy link
Contributor

FR Passed. See JIRA ticket for details. PR ready to be merged.

@ssaddique ssaddique merged commit 30549ae into tidev:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @nguyen8427 @ssaddique @janvennemann