Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): obtain holder for module references #11498

Merged
merged 7 commits into from Apr 14, 2020

Conversation

garymathews
Copy link
Contributor

  • Obtain module instance when holder cannot be found.
TEST CASE
const permissions = Ti.Filesystem.requestStoragePermissions;
 
// Attempt to call 'requestStoragePermissions'.
permissions(e => {
    if (e.success) {
        console.log('Storage permissions granted.');
        return;
    }
    console.warn('Storage permissions denied.');
});
  • Should see a console log regarding storage permissions.
  • Should not see
Couldn't obtain argument holder

JIRA Ticket

@build
Copy link
Contributor

build commented Feb 25, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 4 tests have failed There are 4 tests failing and 698 skipped out of 7357 total tests.

Tests:

ClassnameNameTimeError
android.emulator.fs#copyFile() copies file asynchronously to destination (9)18.805
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)
android.emulator.Titanium.UI.ListViewlistView with Ti.UI.Android.CardView (9)60.044
Error: timeout of 60000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.Window#addSharedElement() (9)11.361
Error: timeout of 10000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)
ios.ipad.Titanium.Network.HTTPClientsetCookieClearCookieWithMultipleHTTPClients (13.2.2)59.999
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/EEC19174-569F-4A45-931A-958D2E6C8BF7/data/Containers/Bundle/Application/C3B8A2E3-94C4-4226-B76F-A3133078C726/mocha.app/ti-mocha.js:6535:53732

Generated by 🚫 dangerJS against 6cccf94

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssekhri
Copy link

ssekhri commented Apr 14, 2020

FR Passed.
Don't see the error "Couldn't obtain argument holder"
The permission is requested on the device and log message are seen based on allow/reject of permission.
Verified on:
Mac OS: 10.15.4
SDK: 9.1.0.v20200413125029
Appc CLI: 8.0.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202003181504
Device: Pixel3(v10.0) emulator

@sgtcoolguy sgtcoolguy merged commit 1315d85 into tidev:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants