Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): prevent unnecessary channelId warning #11500

Merged
merged 3 commits into from Mar 27, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Feb 25, 2020

  • Prevent unnecessary default notification channel warning in logs.
  • Add missing channelId in docs.
TEST CASE
const channel = Ti.Android.NotificationManager.createNotificationChannel({
    id: 'my_channel',
    name: 'TEST CHANNEL',
    importance: Ti.Android.IMPORTANCE_DEFAULT
});
const notification = Ti.Android.createNotification({
    icon: Ti.Android.R.drawable.ic_dialog_info,
    contentTitle: 'TITLE',
    contentText : 'This is a test',
    channelId: channel.getId()
});

Ti.Android.NotificationManager.notify(100, notification);
  • Should not see this warning in logs:
Falling back to default notification channel.

JIRA Ticket

@build build requested review from a team February 25, 2020 18:49
@build build added the docs label Feb 25, 2020
@build
Copy link
Contributor

build commented Feb 25, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6626 tests are passing.
(There are 699 skipped tests not included in that total)

Generated by 🚫 dangerJS against fc1983b

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir
Copy link
Contributor

FR Passed: No longer get the above log message when using a custom channel.

Environment

MacOS Catalina: 10.15.1 beta
Xcode: 11.3
Java Version: 1.8.0_131
Android NDK: 18.1.5063045
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Pixel xl (7.1.1) Emulator 

@sgtcoolguy sgtcoolguy merged commit 2c067cd into tidev:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants