New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(buffer): allow setting falsy values through proxy #11512
Conversation
|
FR Passed Test Environment My testing has found that this bug affects only iOS 13 devices. < iOS 13 there is no error and result displays as expected. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-27785
setAdjustedIndex
was returning the value it did set on the buffer. this value was used as the return value for the proxy's set handler. returning falsy values from there means that the handler failed setting the value which results in error messages likeProxy object's 'set' trap returned falsy value for property '0'
This fixes the handler by always returning true. I also removed the return statement from
setAdjustedIndex
as it is not used anywhere else.