Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android)(9_0_X): add "google-services.json" support #11514

Merged
merged 5 commits into from Apr 15, 2020

Conversation

jquick-axway
Copy link
Contributor

@build
Copy link
Contributor

build commented Mar 3, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6581 tests are passing.
(There are 705 skipped tests not included in that total)

Generated by 🚫 dangerJS against 4147819

@m1ga
Copy link
Contributor

m1ga commented Apr 11, 2020

@hansemannn with this PR firebase-auth works.

@hansemannn
Copy link
Collaborator

Jep, thx! I really hope this makes it into 9.0.1. Can't update to 9.x before this.

@jquick-axway
Copy link
Contributor Author

@hansemannn, @m1ga, are you unable to update your firebase modules until this change makes it in?

@m1ga
Copy link
Contributor

m1ga commented Apr 13, 2020

@jquick-axway in my tests I can't use the latest versions of the modules because of string not found errors. I was able to use firebase-core + firebase-cloud-messaging with a lower version e.g. fcm 20.0.1 so it will work.
But firebase-auth won't work without the patch. Here is a test version: http://migaweb.de/firebase.auth-android-3.0.0.zip if you just include it inside the tiapp.xml it will crash with a string not found error. As soon as I use this PR and put the google-service.json in the right place it works fine.

I didn't try to update the other modules to the latest module versions yet since I have a setup now that works and I don't want to change it :)

@jquick-axway
Copy link
Contributor Author

jquick-axway commented Apr 13, 2020

That's what I was afraid of. For your info, the google-services gradle tool turns the JSON into string xml entries under the "res" folder. So, it's failing to find these string resources.

@hansemannn
Copy link
Collaborator

Yep, that was exactly our issue. We used a local fork that includes the patch now, so once this is merged, we can go official again!

@ssekhri
Copy link

ssekhri commented Apr 15, 2020

FR Passed
Mac OS: 10.15.4
SDK: 9.0.1.v20200413124532
Appc CLI: 8.0.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202003181504
Device: Pixel3(v10.0) emulator

@ssekhri ssekhri merged commit 5422e25 into tidev:9_0_X Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants