Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): add missing console.trace #11540

Closed
wants to merge 3 commits into from

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann commented Mar 13, 2020

JIRA: https://jira.appcelerator.org/browse/TIMOB-27808

Add missing console.trace back to the console rewrite. Looks like we missed that.

Note that on NodeJS, trace does prefix the message with Trace: and captures a stack trace that will also be printed. I didn't add that since we had trace in our native console implementation which just printed with the trace log level. I decided to just fix the regression and not adopt any additional functionality from Node here.

@janvennemann janvennemann added this to the 9.1.0 milestone Mar 13, 2020
@build
Copy link
Contributor

build commented Mar 13, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 472 skipped out of 4832 total tests.

Tests:

ClassnameNameTimeError
android.emulator.console.constructoraccepts stdout, stderr, ignoreErrors arguments (9)0.003
Error: expected 3 to equal 2
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/console.test.js:306:27)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
ios.iphone.console.constructoraccepts stdout, stderr, ignoreErrors arguments (13.2.2)0
Error: expected 3 to equal 2
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/console.test.js:306:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/9B3CCF67-F11D-4BDC-99E9-7872B8E74921/data/Containers/Bundle/Application/D2B964A6-309A-4EF6-8494-FB1B9481075F/mocha.app/ti-mocha.js:5764:23

Generated by 🚫 dangerJS against af20d17

@ssjsamir ssjsamir self-requested a review March 23, 2020 13:10
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to see console traces in logs.

Environment

MacOS Catalina: 10.15.1 beta
Xcode: 11.3
Java Version: 1.8.0_131
Android NDK: 18.1.5063045
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Pixel xl (7.1.1) Emulator

@sgtcoolguy
Copy link
Contributor

rebased and merged manually.

@sgtcoolguy sgtcoolguy closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants