Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(9_0_X): prevent unnecessary channelId warning #11559

Merged
merged 3 commits into from Mar 27, 2020

Conversation

garymathews
Copy link
Contributor

@build
Copy link
Contributor

build commented Mar 24, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 703 skipped out of 7259 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.Network.HTTPClientTIMOB-23214 (13.2.2)60.001
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3C5AF20-9032-4C42-AD05-7A080920757F/data/Containers/Bundle/Application/0DFC1110-8996-45DE-A816-732C5EFAFE8F/mocha.app/ti-mocha.js:6535:53732

Generated by 🚫 dangerJS against c3ad085

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir ssjsamir self-requested a review March 25, 2020 13:32
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garymathews When trying to build this PR I get the following error.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':titanium:generateJsonModelRelease'.
> Expected NDK STL shared object file at /Users/Samir/Library/Android/sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/libs/armeabi-v7a/libgnustl_shared.so

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 957ms
14 actionable tasks: 1 executed, 13 up-to-date
"gradlew" tool returned exit code: 1

@sgtcoolguy
Copy link
Contributor

@ssjsamir I had the same thing happening locally. I don't know what eventually fixed it (I updated to NDK r19 van home-brew, but I think I still had to manually delete some generated dirs like .gradle/dist/other build dirs)

@sgtcoolguy sgtcoolguy merged commit a7dc68b into tidev:9_0_X Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants