Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(9_0_X): obtain holder for module references #11561

Merged
merged 5 commits into from Apr 14, 2020
Merged

fix(android)(9_0_X): obtain holder for module references #11561

merged 5 commits into from Apr 14, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 9.0.1 milestone Mar 24, 2020
@garymathews garymathews changed the base branch from master to 9_0_X March 24, 2020 21:34
@build
Copy link
Contributor

build commented Mar 24, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6584 tests are passing.
(There are 704 skipped tests not included in that total)

Generated by 🚫 dangerJS against 679094a

@ssekhri
Copy link

ssekhri commented Apr 14, 2020

FR Passed.
Don't see the error "Couldn't obtain argument holder"
The permission is requested on the device and log message are seen based on allow/reject of permission.
Verified on:
Mac OS: 10.15.4
SDK: 9.0.1.v20200413125619
Appc CLI: 8.0.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202003181504
Device: Pixel3(v10.0) emulator

@sgtcoolguy sgtcoolguy merged commit 764f024 into tidev:9_0_X Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @ssekhri @sgtcoolguy