Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(9_0_X): autoFocus causing crash on some versions of Android #11562

Merged
merged 3 commits into from Mar 26, 2020

Conversation

garymathews
Copy link
Contributor

Scott Null and others added 2 commits March 24, 2020 14:36
Crash occurs on some devices running Android versions 5.01, 5.1 and 6.0.1 when taking a picture.
@build
Copy link
Contributor

build commented Mar 24, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6534 tests are passing.
(There are 703 skipped tests not included in that total)

Generated by 🚫 dangerJS against 5884951

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir ssjsamir self-requested a review March 26, 2020 13:09
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Autofocus no longer causing crashes on a variety of devices/android versions.

Environment

MacOS Catalina: 10.15.1 beta
Xcode: 11.3
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Pixel xl (7.1.1) 
Nexus 60(8.0)
Pixel XL (10)
Samsung Galaxy S4 (5.1)

@ssjsamir ssjsamir merged commit ab3d8c6 into tidev:9_0_X Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants