Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(9_0_X): fall through request permissions #11563

Merged
merged 2 commits into from Apr 9, 2020
Merged

fix(android)(9_0_X): fall through request permissions #11563

merged 2 commits into from Apr 9, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 9.0.1 milestone Mar 24, 2020
@build build requested a review from a team March 24, 2020 22:23
@build
Copy link
Contributor

build commented Mar 24, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6414 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 04a34d1

jquick-axway
jquick-axway approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir ssjsamir self-requested a review April 9, 2020 12:30
ssjsamir
ssjsamir approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed Able to see that permissions are accepted using the test case from #11496

Environment

MacOS Catalina: 10.15.5 Beta 
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Pixel Xl 10.0

@sgtcoolguy sgtcoolguy merged commit 7bede6f into tidev:9_0_X Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssjsamir ssjsamir ssjsamir approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @ssjsamir @jquick-axway @sgtcoolguy