fix(iOS)(9_0_X): use searchtextfield exposed in iOS 13 to set color #11566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vijaysingh-axway
changed the title
janvennemann
approved these changes
Mar 30, 2020
| [self setHintTextColor_:[[self proxy] valueForUndefinedKey:@"hintTextColor"]]; | ||
| if ([TiUtils isIOSVersionOrGreater:@"13.0"]) { | ||
| // Need to call a bit later to get searchTextField loaded | ||
| [self performSelector:@selector(setHintTextColor_:) withObject:[[self proxy] valueForUndefinedKey:@"hintTextColor"] afterDelay:.01]; |
There was a problem hiding this comment.
Do you have more info why this is required? I'd love to know why this only works after adding the delay.
There was a problem hiding this comment.
In debugging I found that SearchTextField inside searchbar takes sometime to load and before loading the searchTextField setting this property is not working.
ssjsamir
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
FR Passed using the following test case, able to set colour to search field and hint.
var win = Ti.UI.createWindow({
backgroundColor: '#fff'
});
var searchBar = Ti.UI.createSearchBar({
color: 'red',
barColor: 'gray',
showCancel: 'true',
hintTextColor: 'red',
hintText: 'Enter Value',
height: 43,
top: 100
});
win.add(searchBar);
win.open();
Environment
MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
iphone 8 Sim (13.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-27754