Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): assume application/javascript is not binary #11568

Merged
merged 2 commits into from Mar 30, 2020
Merged

fix(android): assume application/javascript is not binary #11568

merged 2 commits into from Mar 30, 2020

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-27823

Optional Description:
Android 29+ reports js content mime type as application/javascript. Used to report text/javascript. As a result our blob code that sniffed if it's contents were binary were assuming js files were binary.

@sgtcoolguy sgtcoolguy mentioned this pull request Mar 25, 2020
Merged
@build build added this to the 9.1.0 milestone Mar 25, 2020
@build build requested a review from a team March 25, 2020 18:02
@build build added the android label Mar 25, 2020
@build
Copy link
Contributor

build commented Mar 25, 2020

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6615 tests are passing.
(There are 699 skipped tests not included in that total)

Generated by 🚫 dangerJS against c4470c4

garymathews
garymathews approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@sgtcoolguy sgtcoolguy merged commit a6ada8a into tidev:master Mar 30, 2020
@sgtcoolguy sgtcoolguy deleted the TIMOB-27823 branch March 30, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android in-qe-testing 🕵
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgtcoolguy @build @garymathews