Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS)(9_0_X): Search Bar color property does not work with showCancel property in iOS 10 #11573

Merged
merged 3 commits into from Apr 9, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.0.1 milestone Mar 26, 2020
@build build requested a review from a team March 26, 2020 00:13
@build
Copy link
Contributor

build commented Mar 26, 2020

Warnings
⚠️

Commit b3ec30afa91e377a0482f60eb14bca09bdb23311 has a message "fix(ios): color property does not work with showCancel property in search bar" giving 1 errors:

  • header must not be longer than 72 characters, current length is 78
Messages
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖

✅ All tests are passing
Nice one! All 4490 tests are passing.
(There are 458 skipped tests not included in that total)

Generated by 🚫 dangerJS against 6395683

@ssjsamir ssjsamir self-requested a review April 7, 2020 12:42
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vijaysingh-axway I am unable to see the changes on iOS 13.4 (iphone 8 simulator) but with the master PR I am able to (#11572)

@vijaysingh-axway
Copy link
Contributor Author

@vijaysingh-axway I am unable to see the changes on iOS 13.4 (iphone 8 simulator) but with the master PR I am able to (#11572)

This change fix issue in iOS 10. DO you mean the behavior is not expected in iOS 13.4?

@vijaysingh-axway
Copy link
Contributor Author

@ssjsamir PR #11566 fixes the iOS 13 issue, which is not merged yet.

@ssjsamir ssjsamir self-requested a review April 8, 2020 12:12
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed Now that #11566 is merged. Tested using the following test case:

var win = Ti.UI.createWindow({
backgroundColor: '#fff'
});
 
var searchBar = Ti.UI.createSearchBar({
color: 'red',
barColor: 'gray',
showCancel: 'true',
hintTextColor: 'red',
hintText: 'Enter Value',
height: 43,
top: 100
});
 
win.add(searchBar);
win.open();

Environment

MacOS Catalina: 10.15.5 Beta 
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
iphone 8 Sim (10.3)

@sgtcoolguy sgtcoolguy merged commit e013135 into tidev:9_0_X Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants