Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(android)(9_0_X): replace SDK "build.properties" with "BuildConfig" #11606

Merged
merged 1 commit into from Apr 8, 2020
Merged

refactor(android)(9_0_X): replace SDK "build.properties" with "BuildConfig" #11606

merged 1 commit into from Apr 8, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway
refactor(android): replace SDK build.properties with BuildConfig
16b4db1 
- Used to provide Titanium SDK version string, version code, build time, and build hash.
@jquick-axway jquick-axway added this to the 9.0.1 milestone Apr 8, 2020
garymathews
garymathews approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

Also verified app outputs: Powered by Titanium 9.0.1.16b4db1d

@build
Copy link
Contributor

build commented Apr 8, 2020 •
edited

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6559 tests are passing.
(There are 703 skipped tests not included in that total)

Generated by 🚫 dangerJS against 16b4db1

@lokeshchdhry
Copy link
Contributor

FR Passed.

The info looks good & the app version changes.

Studio Ver: 6.0.0.202003181504
SDK Ver: 9.0.1 local build
OS Ver: 10.15.4
Xcode Ver: Xcode 11.4
Appc NPM: 5.0.0
Appc CLI: 8.0.0
Daemon Ver: 3.2.0
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.6
Node Ver: 12.13.1
NPM Ver: 6.12.1
Java Ver: 11.0.1
Android Devices: ⇨ google Pixel (Android 10)

@lokeshchdhry lokeshchdhry merged commit 2ca1f46 into tidev:9_0_X Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @lokeshchdhry @garymathews