New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): navigationWindow open/close event #11607
Conversation
|
android/modules/ui/src/java/ti/modules/titanium/ui/NavigationWindowProxy.java
Outdated
Show resolved
Hide resolved
af4b675
to
fb874c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
nav.addEventListener('open', _ => { | ||
navigation.close(); | ||
}); | ||
nav.addEventListener('close', _ => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.ui.navigationwindow.addontest.js line 33 – '' is defined but never used. Allowed unused args must match /^.+/u. (no-unused-vars)
/* eslint no-unused-expressions: "off" */ | ||
'use strict'; | ||
|
||
describe.windowsMissing('Titanium.UI.NavigationWindow', _ => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.ui.navigationwindow.addontest.js line 11 – '' is defined but never used. Allowed unused args must match /^.+/u. (no-unused-vars)
|
||
it('open/close events', finish => { | ||
const window = Ti.UI.createWindow(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 tests/Resources/ti.ui.navigationwindow.addontest.js line 25 – Trailing spaces not allowed. (no-trailing-spaces)
}); | ||
nav.addEventListener('close', _ => { | ||
finish(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 tests/Resources/ti.ui.navigationwindow.addontest.js line 35 – Expected indentation of 2 tabs but found 8 spaces. (indent)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed using the test case in the description above.
Test Environment
MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Andoird Pixl xl 7.1.1 Emulator
}); | ||
|
||
it('open/close events', finish => { | ||
const window = Ti.UI.createWindow(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 tests/Resources/ti.ui.navigationwindow.addontest.js line 24 – Expected indentation of 2 tabs but found 8 spaces. (indent)
window: window | ||
}); | ||
|
||
nav.addEventListener('open', _ => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.ui.navigationwindow.addontest.js line 30 – '' is defined but never used. Allowed unused args must match /^.+/u. (no-unused-vars)
JIRA: https://jira.appcelerator.org/browse/TIMOB-27834
TEST CASE