Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(9_0_X): module build to download ndk with gradle tool 3.5.0+ #11620

Merged
merged 4 commits into from Apr 30, 2020
Merged

fix(android)(9_0_X): module build to download ndk with gradle tool 3.5.0+ #11620

merged 4 commits into from Apr 30, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway
fix(android): module build to download ndk with gradle tool 3.5.0+
27c5226 
- After updating Android gradle tool from 3.4.x to 3.6.0, module builds no longer auto-downloads NDK if missing.
- Issue on Google's end which default to an "unstable" NDK version and tool does not support downloading unstable versions.
@jquick-axway jquick-axway added this to the 9.0.2 milestone Apr 10, 2020
@build
Copy link
Contributor

build commented Apr 10, 2020 •
edited

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 4500 tests are passing.
(There are 450 skipped tests not included in that total)

Generated by 🚫 dangerJS against 9df9ada

garymathews
garymathews approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@jquick-axway
chore(android): default to older ndk version for modules
ae5f7e7 
- Downgraded default NDK version for modules from 21.0.6113669 to 20.1.5948944
  * Avoids harmless "bad file descriptor" errors that get logged by newest NDK.
@ssekhri
Copy link

ssekhri commented Apr 30, 2020

FR Passed.

  1. With no NDK on the system, the module build installs side-by-side NDK
  2. When side-by-side NDK (any other version) is already installed the module build does not install the NDK
  3. When side-by-side NDK is not installed but another NDK is on the system. "appc ti config" does not have flag for android.ndkPath set then the build for module installs side-by-side NDK.
  4. When side-by-side NDK is not installed but another NDK is on the system. "appc ti config" flag for android.ndkPath is set to the NDK on the system then the module build does not install side-by-side NDK.

Verified on:
Mac OS: 10.15.4
SDK: 9.0.2.v20200429095029
Appc CLI: 8.0.0
JDK: 13.0.2
Node: 10.17.0

@sgtcoolguy sgtcoolguy merged commit 7545627 into tidev:9_0_X Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @ssekhri @garymathews @sgtcoolguy