Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android)(9_0_X): add NDK side-by-side support #11626

Merged
merged 1 commit into from Apr 14, 2020
Merged

feat(android)(9_0_X): add NDK side-by-side support #11626

merged 1 commit into from Apr 14, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Apr 13, 2020 •
edited

@jquick-axway
feat(android): add NDK side-by-side support
b58a59f 
- Updated "node-titanium-sdk" from 4.3.1 to 4.4.0.
- Now detects NDK side-by-side installation paths. Introduced by Google in 2019.
@jquick-axway jquick-axway added this to the 9.0.1 milestone Apr 13, 2020
@build
Copy link
Contributor

build commented Apr 13, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6524 tests are passing.
(There are 703 skipped tests not included in that total)

Dependencies with modified semantic versioning:

Generated by 🚫 dangerJS against b58a59f

garymathews
garymathews approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssekhri
Copy link

ssekhri commented Apr 14, 2020

FR Passed.
The titanium mobile project builds successfully with following scenarios:

  1. No NDK installed
  2. Empty NDK folder in ~/Library/Android/sdk/
  3. Multiple NDK versions installed in ~/Library/Android/sdk/ndk but ti config has no entry for the flag android.ndkPath
  4. Multiple NDK versions installed in ~/Library/Android/sdk/ndk and ti config has entry for the flag android.ndkPath set to one of the ndk versions.

The titanium modules build successfully with scenario 3 and 4.

Verified on:
Mac OS: 10.15.4
SDK: 9.0.1.v20200413162004
Appc CLI: 8.0.0
JDK: 11.0.4
Node: 10.17.0

@ssekhri ssekhri merged commit 0935163 into tidev:9_0_X Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @ssekhri @garymathews