Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add NDK side-by-side support #11627

Merged
merged 2 commits into from Apr 14, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Apr 13, 2020

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27755

Summary:

  • Added NDK side-by-side folder lookup.
    • This is where Android Studio currently installs NDK as of 2019.
    • This folder contains multiple NDK installations.
    • The "ndk-bundle" subdirectory is now deprecated.
  • Updated "node-titanium_sdk" from 5.0.0 to 5.1.0.

Test:

  1. Uninstall NDK if currently installed.
  2. Open Android Studio's preferences window.
  3. Go to: Appearances & Behavior -> System Settings -> Android SDK
  4. Click on the "SDK Tools" tab.
  5. Check the "NDK (Side by side)" option.
  6. Click the OK button.
  7. Verify that you can build a Titanium app without failure.

- Updated "node-titanium-sdk" from 5.0.0 to 5.1.0.
- Now detects NDK side-by-side installation paths. Introduced by Google in 2019.
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@build
Copy link
Contributor

build commented Apr 13, 2020

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6637 tests are passing.
(There are 697 skipped tests not included in that total)

Dependencies with modified semantic versioning:

Generated by 🚫 dangerJS against ed6d996

@ssekhri
Copy link

ssekhri commented Apr 14, 2020

FR Passed.
The titanium mobile project builds successfully with following scenarios:

  1. No NDK installed
  2. Empty NDK folder in ~/Library/Android/sdk/
  3. Multiple NDK versions installed in ~/Library/Android/sdk/ndk but ti config has no entry for the flag android.ndkPath
  4. Multiple NDK versions installed in ~/Library/Android/sdk/ndk and ti config has entry for the flag android.ndkPath set to one of the ndk versions.

The titanium modules build successfully with scenario 3 and 4.

Verified on:
Mac OS: 10.15.4
SDK: 9.1.0.v20200413161210
Appc CLI: 8.0.0
JDK: 11.0.4
Node: 10.17.0

@lokeshchdhry lokeshchdhry merged commit 71f25e8 into tidev:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants