Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): update view controller’s frame according to safe area #11632

Merged
merged 2 commits into from Apr 15, 2020
Merged

fix(ios): update view controller’s frame according to safe area #11632

merged 2 commits into from Apr 15, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway commented Apr 15, 2020 •
edited by jquick-axway

@build build added this to the 9.1.0 milestone Apr 15, 2020
@build build requested a review from a team April 15, 2020 20:19
@build
Copy link
Contributor

build commented Apr 15, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6668 tests are passing.
(There are 689 skipped tests not included in that total)

Generated by 🚫 dangerJS against 30cab44

@ssekhri
Copy link

ssekhri commented Apr 15, 2020

FR Passed. The iPad popover are shown correctly and the title text is centrally aligned.
Verified on:
Mac OS: 10.15.4
SDK: 9.1.0.v20200415124631
Appc CLI: 8.0.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202003181504
Xcode: 11.4
iOS simulator: iPad Air3(v13.4, 12.2), iPad Pro 9.7-inch(v13.4, 12.2), iPad Pro 11-inch(v13.4, 12.2), iPad Pro 12.9-inch(v13.4, 12.2)

@ssekhri ssekhri merged commit edb9ec6 into tidev:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug ios no tests
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vijaysingh-axway @build @ssekhri