Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9_0_X] fix: inline short version string for Ti.version #11635

Merged
merged 4 commits into from Apr 21, 2020

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-27849

Optional Description:
Backport of #11634

Already merged to master, this is a backport PR to be merged into 9_0_X once 9.0.1 has been released.

match regexps for Ti.version, buildHash, buildDate
clean up test code
@sgtcoolguy sgtcoolguy added this to the 9.0.2 milestone Apr 15, 2020
@sgtcoolguy sgtcoolguy changed the title Timob 27849 9 0 x [9_0_X] fix: inline short version string for Ti.version Apr 15, 2020
@build
Copy link
Contributor

build commented Apr 15, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6590 tests are passing.
(There are 696 skipped tests not included in that total)

Generated by 🚫 dangerJS against d56375e

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssekhri
Copy link

ssekhri commented Apr 21, 2020

FR Passed.
Mac OS: 10.15.4
SDK: 9.0.2.v20200417072346
Appc CLI: 8.0.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202003181504
Device: Android emulator v10, iOS simulator v13.4

@ssekhri ssekhri merged commit 7dfc104 into tidev:9_0_X Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants