Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(9_0_X): app/module builds fail with JDK 14 #11637

Merged
merged 5 commits into from Apr 27, 2020
Merged

fix(android)(9_0_X): app/module builds fail with JDK 14 #11637

merged 5 commits into from Apr 27, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 9.0.2 milestone Apr 16, 2020
@build
Copy link
Contributor

build commented Apr 16, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6590 tests are passing.
(There are 696 skipped tests not included in that total)

Generated by 🚫 dangerJS against f220162

garymathews
garymathews approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jquick-axway
chore(android): change gradle distribution type to "all"
fadda2c 
- Enables code completion in "build.gradle" files.
@ssekhri
Copy link

ssekhri commented Apr 27, 2020

FR Passed. App and module builds fine with different java versions(11,13,14)
Verified on:
Mac OS: 10.15.4
SDK: 9.0.2.v20200417073305
Appc CLI: 8.0.0
JDK: 11.0.6, 13.0.2, 14.0.1
Node: 10.17.0
Studio: 6.0.0.202003181504
Device: Pixel3(v10.0) emulator

@ssekhri ssekhri merged commit ba456bf into tidev:9_0_X Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android bug improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @ssekhri @garymathews @sgtcoolguy