Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): animate elevation #11646

Merged
merged 6 commits into from Apr 28, 2020
Merged

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Apr 19, 2020

JIRA: https://jira.appcelerator.org/browse/AC-6531

Being able to animate the elevation value.
Also removed some of the pre-Honeycomb stuff.

var win = Ti.UI.createWindow({
	layout: "vertical",
	backgroundColor: "#fff"
});

var v = Ti.UI.createView({
	elevation: 20,
	width: 200,
	height: 200,
	top: 50,
	backgroundColor:"#fff"
});
var v2 = Ti.UI.createView({
	width: 200,
	height: 200,
	top: 50,
	backgroundColor:"#fff"
});

win.add([v,v2]);

setTimeout(function(){
	v.animate({
		duration: 2000,
		elevation: 0,
		autoreverse:true,
		repeat: 10
	});
	v2.animate({
		duration: 2000,
		elevation: 20,
		autoreverse:true,
		repeat: 10
	});
}, 1000)

win.open();

@build build added this to the 9.1.0 milestone Apr 19, 2020
@build build requested a review from a team April 19, 2020 13:58
@build
Copy link
Contributor

build commented Apr 19, 2020

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Warnings
⚠️

Commit 981e5f663bf5e611ce2f558c6c007156abca79e7 has a message "fallback value" giving 2 errors:

  • subject may not be empty
  • type may not be empty
⚠️

Commit cac63eb888afc85a2990bd2364c9cd23310470ce has a message "fix" giving 2 errors:

  • subject may not be empty
  • type may not be empty
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖

✅ All tests are passing
Nice one! All 6627 tests are passing.
(There are 708 skipped tests not included in that total)

Generated by 🚫 dangerJS against 8f74a2e

@jquick-axway jquick-axway self-requested a review April 20, 2020 15:48
@build build added the docs label Apr 21, 2020
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir ssjsamir self-requested a review April 24, 2020 12:54
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to see elevation in the animation from the test case provided above

Test Environment

MacOS Catalina: 10.15.5 Beta 
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Pixel Xl 7.1.1 Sim

@sgtcoolguy sgtcoolguy merged commit 38a82ed into tidev:master Apr 28, 2020
@m1ga m1ga deleted the animateElevation branch August 7, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants