New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): animate color #11658
feat(android): animate color #11658
Conversation
|
fixed the merge conflict and since #11646 is merged this one looks better now 😄 |
e4580c2
to
41abf79
Compare
Sorry @m1ga don't mean to stomp on your commits here, but I had been working on a rebase and cleanup locally too... so I force-pushed that to your branch 😅 The unit test you have is nice - but ultimately I have to disable it because:
Both are not your issue/fault. The latter has always bothered me. Ideally someday when an animation is done we'd push back the new values to the view's changed properties so querying them post-animation is correct. |
/* eslint no-unused-expressions: "off" */ | ||
'use strict'; | ||
const should = require('./utilities/assertions'); | ||
const utilities = require('./utilities/utilities'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.ui.label.addontest.js line 11 – 'utilities' is assigned a value but never used. (no-unused-vars)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: Able to see text animate and change colour using the test case above. PR can be merged once a CR is done.
Test Environment
MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
Pixel Xl 7.1.1 Sim
@sgtcoolguy no problem 👍 you'll make it work somehow 😄 |
merge after #11646
Since the other PR #11646 is already approved I've used it as the master to this PR since it changing the same file.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27855
Being able to animate the
color
value.