feat(android): tabgroup badge number

[m1ga]

JIRA: https://jira.appcelerator.org/browse/TIMOB-27859

• badge >= 0 will show the badge
• badge = null will remove it

function createTab(title) {
	var window = Ti.UI.createWindow({ title: title , theme: "Theme.MyTheme"});
	window.add(Ti.UI.createLabel({ text: title + " View" }));
	var tab = Ti.UI.createTab({
		title: title,
		icon: "/assets/images/tab1.png",
		badgeColor: "#f00",
		window: window,
	});
	return tab;
}

var tabGroupSettings = {
	tabs: [createTab("Tab 1"), createTab("Tab 2"), createTab("Tab 3")],
};
if (OS_ANDROID) {
	tabGroupSettings.shiftMode = false;
	tabGroupSettings.style = Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION;
}
var tabGroup = Ti.UI.createTabGroup(tabGroupSettings);
tabGroup.addEventListener("open", function() {
	tabGroup.tabs[1].badge = "42";


	setTimeout(function(){
		tabGroup.tabs[1].badge = null;

		setTimeout(function(){
			tabGroup.tabs[1].badge = "23";
		}, 2000)
	}, 2000)
});
tabGroup.open();

[build]

	Fails
🚫	Tests have failed, see below for more information.

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	❌ 2 tests have failed There are 2 tests failing and 984 skipped out of 10919 total tests.

Tests:

Classname	Name	Time	Error
ios.ipad.Titanium.UI.iOS.CollisionBehavior.example	works (14.0)	15.003	Error: timeout of 15000ms exceeded file:///Users/build/Library/Developer/CoreSimulator/Devices/6C7D2BAE-178F-423C-B035-5B9A681D728F/data/Containers/Bundle/Application/D3460814-D13F-4EA1-B27E-E2AEC9A83F36/mocha.app/ti-mocha.js:4326:27
ios.macos.Titanium.UI.iOS.CollisionBehavior.example	works (10.15.4)	15.138	Error: timeout of 15000ms exceeded file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-11659/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4326:27

Generated by 🚫 dangerJS against a35679d

[m1ga]

added the missing badgeColor

[sgtcoolguy]

@m1ga Hope you don't mind - I've rebased this PR on master, fixed the merge conflicts, cleaned up the commits and added tests.

[m1ga]

@sgtcoolguy 👍 no problem, glad it is not forgotten or closed 😄

[jquick-axway]

@m1ga , PR #11921 changes Titanium default app theme to Theme.MaterialComponents.Bridge which maintains the exact same dark theme Theme.AppCompat uses (because it derives from it), but also provides the styles needed by Google's material widgets such as tab badges.

If we merge my PR first, then we don't need to change the unit test suite's app theme. We should still document that the material theme is required by this feature since many (or most?) Titanium developers tend to set up their own app theme which typically derives from an AppCompat theme.

[m1ga]

@jquick-axway I already have On the Android platform you will need to use a Theme with parent="Theme.MaterialComponents.*" in order to use a badge. in the apidoc. Should be enough, or?

[jquick-axway]

@m1ga, yes, your api doc changes are fine. Once my PR is merged, we can remove the following unit test files from this PR since my PR already makes MaterialComponents the default theme. (Sorry for not being clear.)

• build/lib/test/test.js
• tests/platform/android/res/values/styles.xml

[jquick-axway]

@m1ga , can you remove the following files from this PR please?
(Or we can do it if you're too busy.)

• build/lib/test/test.js
• tests/platform/android/res/values/styles.xml

PR #11921 makes Titanium use the material theme by default and it has now been merged. We want your unit tests to verify that tab badges work with the default theme.

[m1ga]

@jquick-axway I've removed the two files but it is still complaining about a merge conflict with build/lib/test/test.js (and the others).

edit: found the solution 😄

[m1ga]

Added the changes and tested it with your test code. Added a timeout to reset and set it again. Updated the code in the first post

[jquick-axway]

CR: Pass

[jquick-axway]

Thanks @m1ga . Your final changes look great!

[ssjsamir]

FR Passed, Tested using the test case mentioned in the description.

Test Environment

MacOS Big Sur: 11.0 Beta 8
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
Pixel XL (10.0)