Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): added event to detect that screenshot was taken #11665

Merged
merged 1 commit into from Apr 30, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.1.0 milestone Apr 28, 2020
@build build requested review from a team April 28, 2020 20:00
@build build added the docs label Apr 28, 2020
@build
Copy link
Contributor

build commented Apr 28, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 709 skipped out of 7346 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.WebViewprogress event (13.2.2)0.833
Error: expected 'https://www.google.com/#spf=1588103422495' to be equals one of Array [ 'https://www.google.com/', 'https://www.google.com' ]
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/F77CB658-56A6-4456-8790-32B676E15B36/data/Containers/Bundle/Application/947D5A20-D71F-4E31-AFF4-A826A27D516D/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/F77CB658-56A6-4456-8790-32B676E15B36/data/Containers/Bundle/Application/947D5A20-D71F-4E31-AFF4-A826A27D516D/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/F77CB658-56A6-4456-8790-32B676E15B36/data/Containers/Bundle/Application/947D5A20-D71F-4E31-AFF4-A826A27D516D/mocha.app/ti.ui.webview.test.js:733:28

Generated by 🚫 dangerJS against 8e60fd0

@ssjsamir ssjsamir self-requested a review April 29, 2020 14:15
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to see the console indicate a screenshot has been taken, tested with the following test case:

var win = Ti.UI.createWindow({
    backgroundColor: '#fff'
});

win.open();

Ti.App.iOS.addEventListener('screenshotcaptured', function() {
    Ti.API.info('screenshot captured lol');
});

Test Environment

MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
iphone 13.4 SIM

@sgtcoolguy sgtcoolguy merged commit b9df339 into tidev:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants