Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): Ti.UI.Window.barColor cannot be changed after it was appeared #11669

Merged
merged 2 commits into from May 4, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.1.0 milestone Apr 29, 2020
@build build requested a review from a team April 29, 2020 22:37
@build
Copy link
Contributor

build commented Apr 29, 2020

Warnings
⚠️

Commit 1176e6b3fec1cbd8cb85654d3c465a82b3aa6959 has a message "fix(ios): Ti.UI.Window.barColor cannot be changed after it was appeared" giving 1 errors:

  • subject must not be sentence-case, start-case, pascal-case, upper-case
Messages
📖

💾 Here's the generated SDK zipfile.

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖

✅ All tests are passing
Nice one! All 6602 tests are passing.
(There are 709 skipped tests not included in that total)

Generated by 🚫 dangerJS against 0e47897

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, able to see the changes of Ti.UI.Window.barColor using the linked example in: https://jira.appcelerator.org/browse/TIMOB-27868

Test Environment

MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0-1","CLI":"8.0.0-master.10""
iphone 8 sim (ios 13.4)

@sgtcoolguy sgtcoolguy merged commit 5049d8d into tidev:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants