Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ios): deprecated statusbar constant #11678

Merged
merged 1 commit into from May 4, 2020
Merged

chore(ios): deprecated statusbar constant #11678

merged 1 commit into from May 4, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.1.0 milestone May 1, 2020
@build build requested review from a team May 1, 2020 23:40
@build
Copy link
Contributor

build commented May 1, 2020

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Warnings
⚠️

Commit 3f2467a5d36da45119ac4fd6439e57797cd750c6 has a message "chore(iOS): deprecated statusbar constant" giving 1 errors:

  • scope must be lower-case
Messages
📖

💾 Here's the generated SDK zipfile.
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖

✅ All tests are passing
Nice one! All 6637 tests are passing.
(There are 709 skipped tests not included in that total)

Generated by 🚫 dangerJS against 3f2467a

@janvennemann janvennemann changed the title chore(iOS): deprecated statusbar constant chore(ios): deprecated statusbar constant May 4, 2020
@sgtcoolguy sgtcoolguy merged commit 3c83fd8 into tidev:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
docs ios needs tests 🚨
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @janvennemann @sgtcoolguy