New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "isTrusted" property to Slider "change" event #11717
Conversation
Tests:
|
@m1ga, would you mind if I add changes to this PR? |
@jquick-axway no, go ahead! |
- For parity with Android.
PR updated:
@janvennemann, would you mind reviewing the iOS side? Do you have any objections to this new event property? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jquick-axway iOS change looks good. I'm fine with introducing this now since we already fire the event on programmatic changes. Eventually we should stop firing the change
event after programmatic changes though, but as already discussed we can deal with that in a separate ticket for an upcoming major release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed Tested using the test case and instructions mentioned above in the description.
Test Environment
MacOS Big Sur: 11.0 Beta
Xcode: 12.0 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.0.0""
iphone 8 Sim (14.0 Beta)
API29 Pixel XL emulator
Fix verified on build 9.1.0.v20200804082025. Test environment
I must note that when clicking the 'Update' button, the value is logged twice:
|
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27977
Summary:
Added a "isTrusted" boolean property to
Ti.UI.Slider
object's "change" event. Property will betrue
if change came from the end-user. Will befalse
if change was made programmatically. This is a standard JavaScript event property available to web developers. (In the future, we should apply this property to all events.)https://developer.mozilla.org/en-US/docs/Web/API/Event/isTrusted
Test:
isTrusted
property is set totrue
.isTrusted
property is set tofalse
.