Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): start initial timer id from one #11734

Merged
merged 5 commits into from Jun 4, 2020

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann commented May 26, 2020

JIRA: https://jira.appcelerator.org/browse/TIMOB-27898

Optional Description:
We use simple number values as timer identifiers, which used to start from 0. This could cause unexpected behavior when checking for a timer id since it evaluates to a falsy value for the first timer. Always starting and incrementing the timer ids from 1 solves the issue.

@build
Copy link
Contributor

build commented May 26, 2020

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 4388 tests are passing.
(There are 472 skipped tests not included in that total)

Generated by 🚫 dangerJS against 57bca56

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@vijaysingh-axway
Copy link
Contributor

@janvennemann Is it possible to add unit test for this? I think it can be achieved by appending the log message in a string and compare it after completion.

@janvennemann
Copy link
Contributor Author

@vijaysingh-axway I thought about that, but the issue is actually pretty hard to test with our test suite. This issue only occurs for the very first timer started after the app launched. However, we use timers all over the place so i don't even get a chance to test for this particular bug.

@sgtcoolguy sgtcoolguy merged commit 2f01ac1 into tidev:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants