Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): start initial timer id from one (9_0_X) #11735

Merged
merged 2 commits into from Jun 4, 2020

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann commented May 26, 2020

@build
Copy link
Contributor

build commented May 26, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 691 skipped out of 7197 total tests.

Tests:

ClassnameNameTimeError
android.emulator.TitaniumbuildDate (9)0.002
Error: expected '6/3/2020 18:15' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value [as match] (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.test.js:32:22)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
ios.ipad.TitaniumbuildDate (13.4.1)0
Error: expected '6/3/2020 18:15' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/ti.test.js:32:27
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/E3F1E1DC-59CA-47B4-A17A-F5A23F7B37CC/mocha.app/ti-mocha.js:5764:23
ios.iphone.TitaniumbuildDate (13.5)0.001
Error: expected '6/3/2020 18:15' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/ti.test.js:32:27
file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/9873C474-8BB1-42EC-AD3C-C2AE4CCC0828/data/Containers/Bundle/Application/5875A8BE-45C8-4474-A03D-C68BD74129EE/mocha.app/ti-mocha.js:5764:23

Generated by 🚫 dangerJS against b6e14fd

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@build build added this to the 9.0.3 milestone Jun 3, 2020
@sgtcoolguy sgtcoolguy merged commit bbba4cd into tidev:9_0_X Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants