Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): update debugging prefix for chrome #11738

Merged
merged 1 commit into from May 29, 2020

Conversation

ewanharris
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-27912

Chrome 83 drops the chrome prefix and moves to just devtools://

Fixes TIMOB-27912

Chrome 83 drops the chrome prefix and moves to just devtools://

Fixes TIMOB-27912
@build build added this to the 9.1.0 milestone May 29, 2020
@build build requested a review from a team May 29, 2020 12:20
@build
Copy link
Contributor

build commented May 29, 2020

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 703 skipped out of 7367 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Androidactivity callbacks (9)5.024
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)
android.emulator.Titanium.UI.Labelanimate font color (9)2.053
Error: timeout of 2000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against a4c0d49

@sgtcoolguy sgtcoolguy merged commit e4d5074 into tidev:master May 29, 2020
@ewanharris ewanharris deleted the TIMOB-27912 branch August 31, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants