Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(9_0_X): incremental build creates duplicate "bootstrap.json" entries #11745

Closed
wants to merge 1 commit into from

Conversation

jquick-axway
Copy link
Contributor

- Bootstrap file fetching code was moved to core "process-js-task.js" file in 8.1.0.
@build
Copy link
Contributor

build commented Jun 2, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 696 skipped out of 7287 total tests.

Tests:

ClassnameNameTimeError
android.emulator.TitaniumbuildDate (9)0.001
Error: expected '6/2/2020 20:53' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value [as match] (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.test.js:32:22)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
ios.ipad.TitaniumbuildDate (13.4.1)0
Error: expected '6/2/2020 20:53' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/ti.test.js:32:27
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/40E2714C-10EC-482F-B6B7-C1241809078F/mocha.app/ti-mocha.js:5764:23
ios.iphone.TitaniumbuildDate (13.4.1)0.001
Error: expected '6/2/2020 20:53' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/ti.test.js:32:27
file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/63E1E383-8B78-4740-88A1-98657FA0796F/data/Containers/Bundle/Application/4ECEB06C-181F-4503-AB5C-C2B3D919E488/mocha.app/ti-mocha.js:5764:23

Generated by 🚫 dangerJS against e2004ba

@sgtcoolguy
Copy link
Contributor

oops. I had already cherry-picked this!

@sgtcoolguy sgtcoolguy closed this Jun 3, 2020
@jquick-axway
Copy link
Contributor Author

Thanks @sgtcoolguy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants