Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android)(9_0_X): auto-download NDK r21c for module builds if needed #11756

Merged
merged 7 commits into from Jun 9, 2020
Merged

chore(android)(9_0_X): auto-download NDK r21c for module builds if needed #11756

merged 7 commits into from Jun 9, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Jun 5, 2020 •
edited

@jquick-axway
chore(android): auto-download NDK r21c for module builds
ea2ca08 
- This NDK version was notarized for macOS Catalina. Prevents security popups when doing module builds.
@jquick-axway jquick-axway added this to the 9.0.3 milestone Jun 5, 2020
@build
Copy link
Contributor

build commented Jun 5, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6582 tests are passing.
(There are 695 skipped tests not included in that total)

Generated by 🚫 dangerJS against 3b66a00

jquick-axway and others added 6 commits June 4, 2020 21:40
@jquick-axway
fix(android): bad file descriptor errors with NDK v21 builds
bebfc15 
- Compiling with Android NDK 21 and higher would cause several harmless "Bad file descriptor" errors to be logged.
- Caused by NDK 21 setting "--output-sync" argument default. Setting it to "none" restores old behavior.
@jquick-axway
fix(android): only use --output-sync for NDK 21+
324000f 
- Using NDK command line argument --output-sync will cause a build failure on NDK 19 and lower. And we don't need to pass it into NDK 20.
@sgtcoolguy
Merge branch '9_0_X' into TIMOB-27939-9_0_X
2e1e3fa
@sgtcoolguy
Merge branch '9_0_X' into TIMOB-27939-9_0_X
1665bf9
@jquick-axway
chore(android): removed TIMOB-27939 commented-out code
6740ce7
@garymathews
Merge branch '9_0_X' into TIMOB-27939-9_0_X
3b66a00
garymathews
garymathews approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@ssjsamir ssjsamir self-requested a review June 9, 2020 13:00
@ssjsamir
Copy link
Contributor

ssjsamir commented Jun 9, 2020

FR Passed: No longer see Bad file descriptor errors and able to install NDK if no other NDKs are found.

Test Environment

MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0","CLI":"8.0.0""
Andoird Pixl xl 7.1.1 Emulator

@ssjsamir ssjsamir merged commit 0b2fb28 into tidev:9_0_X Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

@ssjsamir ssjsamir ssjsamir approved these changes

Assignees
No one assigned
Labels
android improvement no tests
Projects
None yet
Milestone
9.0.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @ssjsamir @garymathews @sgtcoolguy