Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): update debugging prefix for chrome #11757

Merged
merged 1 commit into from Jun 5, 2020

Conversation

ewanharris
Copy link
Collaborator

Chrome 83 drops the chrome prefix and moves to just devtools://

Fixes TIMOB-27912
@build
Copy link
Contributor

build commented Jun 5, 2020

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 450 skipped out of 4950 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.TitaniumbuildDate (13.4.1)0
Error: expected '6/5/2020 13:24' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/ti.test.js:32:27
file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/455E2DDA-2DF5-4A79-975B-B71735C2C9E6/data/Containers/Bundle/Application/C5EDD671-6B64-44A1-88CD-73588E433DF6/mocha.app/ti-mocha.js:5764:23
ios.iphone.TitaniumbuildDate (13.5)0.001
Error: expected '6/5/2020 13:24' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/ti.test.js:32:27
file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/1F2AD1FD-F703-40AE-A111-84176B0F2BF0/data/Containers/Bundle/Application/8D5425F4-E6C3-4238-9020-0B36BB267EB7/mocha.app/ti-mocha.js:5764:23

Generated by 🚫 dangerJS against f2c7384

@sgtcoolguy sgtcoolguy merged commit edcb376 into tidev:9_0_X Jun 5, 2020
@ewanharris ewanharris deleted the TIMOB-27912_90X branch June 5, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants