New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): implement Shortcut proxy #11759
Conversation
28f90c0
to
8616fb7
Compare
* `Ti.UI.createShortcut` is manually defined in `UIModule`. | ||
*/ | ||
@Kroll.module(parentModule = UIModule.class) | ||
public class ShortcutModule extends KrollModule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels a bit odd to have this module stub so we can hang event listeners. Looks like we also always fire the event at the same time to Ti.App shortcutitemclick
event - so you could probably hack this pretty easily in a js extension (basically add a dumb Ti.UI.Shortcut add/removeEventListener that registers for Ti.App event and forwards it)
FR Passed |
Ti.UI.createShortcut
for cross-platform shortcutsTEST CASE
JIRA Ticket