Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): specify default Tab.tintColor #11777

Merged
merged 5 commits into from Jun 29, 2020

Conversation

garymathews
Copy link
Contributor

  • Always specify default tintColor
TEST CASE
const tabGroup = Ti.UI.createTabGroup({
    // style: Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION
});

const tabWin_home = Ti.UI.createWindow({
    title: 'Home',
    backgroundColor: 'white'
});
const tab_home = Ti.UI.createTab({
    title: 'Home',
    window: tabWin_home
});

const tabWin_chat = Ti.UI.createWindow({
    title: 'Chat',
    backgroundColor: 'white'
});
const tab_chat = Ti.UI.createTab({
    title: 'Chat',
    window: tabWin_chat
});

tabGroup.addTab(tab_home);
tabGroup.addTab(tab_chat);
tabGroup.open();

JIRA Ticket

@garymathews garymathews added this to the 9.1.0 milestone Jun 16, 2020
@build build requested a review from a team June 16, 2020 23:30
@build
Copy link
Contributor

build commented Jun 16, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 698 skipped out of 7346 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Androidactivity callbacks (9)5.01
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)
android.emulator.Titanium.UI.SearchBar.focused (9)2.189
Error: timeout of 2000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.TextArea.focused (9)2.197
Error: timeout of 2000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against 737d019

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@sgtcoolguy
Copy link
Contributor

@garymathews Can we add a simple test that creates a tab group without a specified tint color and verify it returns the expected default value? Also, once # 11699 is merged and I push the test changes to the suite, we can do UI image tests in our suite - so you could create a view/window with a tab group without a specific tintColor, call Ti.UI.View#toImage() and compare versus a known good rendered image (generated by a previous run)

@ssekhri
Copy link

ssekhri commented Jun 23, 2020

FR Passed.
Default tint color is set on tabs in tabgroup.
Verified on:
Mac OS: 10.15.4
SDK: 9.1.0.v20200616161255
Appc CLI: 8.0.0
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Device: Nexus4(v5.1.1) device, Pixel3(v10.0) emulator

@sgtcoolguy sgtcoolguy merged commit 9a6d417 into tidev:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants