Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): event sessioncompleted does not get all specified values #11782

Merged
merged 6 commits into from Jul 6, 2020
Merged

fix(ios): event sessioncompleted does not get all specified values #11782

merged 6 commits into from Jul 6, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.1.0 milestone Jun 19, 2020
@build build requested a review from a team June 19, 2020 00:37
@build
Copy link
Contributor

build commented Jun 19, 2020 •
edited

Warnings
⚠️

Commit f88f4b8596f7f39533c867ed42bc7b6393d9f442 has a message "doc(ios): updated doc" giving 1 errors:

  • type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]
Messages
📖

💾 Here's the generated SDK zipfile.
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖

✅ All tests are passing
Nice one! All 6686 tests are passing.
(There are 698 skipped tests not included in that total)

Generated by 🚫 dangerJS against 8313e7d

@build build requested a review from a team June 19, 2020 19:24
@build build added the docs label Jun 19, 2020
janvennemann
janvennemann approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed, looks good to me! I'll move it to QE review since the notes from @sgtcoolguy are only docs related and can be fixed while QE does the FR.

@ssjsamir ssjsamir self-requested a review July 2, 2020 14:13
ssjsamir
ssjsamir approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, tested using the test cases and instructions mentioned in: https://jira.appcelerator.org/browse/TIMOB-27821?focusedCommentId=455888&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-455888

Test Environment

MacOS Big Sur: 11.0 Beta
Xcode: 12.0 Beta 
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.0.0""
iphone 8 Sim (14.0 Beta)

@sgtcoolguy sgtcoolguy merged commit ebae7bd into tidev:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy left review comments

@janvennemann janvennemann janvennemann approved these changes

@ssjsamir ssjsamir ssjsamir approved these changes

Assignees
No one assigned
Labels
bug docs in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @sgtcoolguy @janvennemann @ssjsamir