feat(android): support touch feedback for all backgrounds or no background #11795

jquick-axway · 2020-06-24T22:40:09Z

JIRA:
https://jira.appcelerator.org/browse/TIMOB-26315

Summary:

The Ti.UI.View properties touchFeedback and touchFeedbackColor used to only show a tap ripple effect when a backgroundColor was applied to the view. This was a documented limitation.
Now shows touch feedback ripple to the following as well:
- backgroundImage
- backgroundGradient
- backgroundColor set to TRANSPARENT
- no background
Note that touch feedback is only applied to a view's background.

Test:

Build and run the below on Android 5.0 or higher.
Tap on "Transparent Background" and verify a yellow ripple appears.
Tap on "White Background" and verify a yellow ripple appears.
Tap on "Gradient Background" and verify a yellow ripple appears.
Tap on "Image Background" and verify a yellow ripple appears only on the image.
Tap on "Custom Button" and verify a yellow ripple appears within the blue button.

var window = Ti.UI.createWindow();
var scrollView = Ti.UI.createScrollView({
	layout: "vertical",
	scrollType: "vertical",
	showHorizontalScrollIndicator: false,
	shorVerticalScrollIndicator: true,
	width: Ti.UI.FILL,
	height: Ti.UI.FILL,
});
scrollView.add(Ti.UI.createLabel({
	text: "\nTransparent\nBackground\n",
	textAlign: Ti.UI.TEXT_ALIGNMENT_CENTER,
	touchFeedback: true,
	touchFeedbackColor: "yellow",
	top: "10dp",
	width: "75%",
}));
scrollView.add(Ti.UI.createLabel({
	text: "\nWhite\nBackground\n",
	textAlign: Ti.UI.TEXT_ALIGNMENT_CENTER,
	color: "black",
	backgroundColor: "white",
	touchFeedback: true,
	touchFeedbackColor: "yellow",
	top: "10dp",
	width: "75%",
}));
scrollView.add(Ti.UI.createLabel({
	text: "\nGradient\nBackground\n",
	textAlign: Ti.UI.TEXT_ALIGNMENT_CENTER,
	color: "white",
	backgroundGradient: {
		type: "linear",
		startPoint: { x: "0%", y: "50%" },
		endPoint: { x: "100%", y: "50%" },
		colors: [ { color: "white", offset: 0.0}, { color: "blue", offset: 1.0 } ],
	},
	touchFeedback: true,
	touchFeedbackColor: "yellow",
	top: "10dp",
	width: "75%",
}));
scrollView.add(Ti.UI.createLabel({
	text: "\nImage\nBackground\n",
	textAlign: Ti.UI.TEXT_ALIGNMENT_CENTER,
	color: "green",
	backgroundImage: "/appicon.png",
	touchFeedback: true,
	touchFeedbackColor: "yellow",
	top: "10dp",
	width: "100dp",
	height: "100dp",
}));
scrollView.add(Ti.UI.createButton({
	title: "Custom Button",
	backgroundImage: "android.resource://android/drawable/panel_picture_frame_bg_focus_blue",
	touchFeedback: true,
	touchFeedbackColor: "yellow",
	top: "10dp",
}));
window.add(scrollView);
window.open();

- Used to only be supported when using "backgroundColor" property. - Now applied to all background types such as: * backgroundImage * backgroungGradient * No background

build · 2020-06-24T23:03:01Z

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	✅ All tests are passing Nice one! All 6649 tests are passing. (There are 698 skipped tests not included in that total)

Generated by 🚫 dangerJS against 52795df

sgtcoolguy · 2020-06-25T19:49:06Z

android/titanium/src/java/org/appcelerator/titanium/view/TiUIView.java

 	 */
-	private void applyTouchFeedback(@NonNull Integer backgroundColor, @Nullable Integer rippleColor)
+	private void applyTouchFeedback(Integer rippleColor)


Any particular reason to drop the @Nullable? I kind of like having it be explicit in our APIs so we can use tools to verify checking for null pointers or not...

Personally, I question the value of the @Nullable annotation. All reference types are implicitly nullable. The only benefit it provides is more for IDE intellisense purposes since it reveals the annotations and effectively documents the API which we can already do via JavaDoc comments.

The @NonNull annotation is far more valuable since we can use it to trigger compiler/linter errors. So, if it doesn't have the @NonNull annotation, then it's assumed nullable.

Anyways, that's my 2 cents. Unless you can think of something else that might benefit from this?

I get that things are implicitly @Nullable (so long as they're not primitives). I saw it more as a marker of what APIs we've "done" since we've got this large legacy codebase that we didn't use the annotations on. If we don't use @Nullable, it's unclear if we've already reviewed the API and decided they're all implicitly nullable, or if we simply haven't gotten around to adding annotations.

sgtcoolguy · 2020-06-25T19:51:02Z

tests/Resources/ti.ui.view.addontest.js

+		}
+	});
+
+	it.android('touchFeedback', (finish) => {


I appreciate the effort in creating a test, but I don't think it's really verifying anything since this is an interactive UI change, correct?

Right. It doesn't verify anything, but it does exercise the native API to make sure it doesn't crash. So, I guess it's better than nothing? 🤷‍♂️

Ideally, QE should test this by hand via a functional/smoke test since this is a visual feature.

sgtcoolguy

The changes LGTM. I don't think the test here would achieve anything, unfortunately so likely this just should be added to QE's UI integration suite if possible.

ssjsamir

FR Passed, tested using the test case in description and following the mentioned test steps.

Test Environment

MacOS Big Sur: 11.0 Beta
Xcode: 12.0 Beta 
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.0.0""
API30 Pixel XL2 emulator

sgtcoolguy · 2020-07-13T18:57:40Z

Fixed conflict and manually merged via rebase on master.

feat(android): support touch feedback for all backgrounds

10bc245

- Used to only be supported when using "backgroundColor" property. - Now applied to all background types such as: * backgroundImage * backgroungGradient * No background

jquick-axway added android improvement labels Jun 24, 2020

jquick-axway added this to the 9.1.0 milestone Jun 24, 2020

jquick-axway requested a review from garymathews June 24, 2020 22:40

jquick-axway mentioned this pull request Jun 24, 2020

feat(android): Allow touch feedback for image and gradient backgrounds #10986

Closed

Merge branch 'master' into TIMOB-26315

52795df

build requested review from a team June 24, 2020 23:47

build added the docs label Jun 24, 2020

sgtcoolguy reviewed Jun 25, 2020

View reviewed changes

sgtcoolguy approved these changes Jun 25, 2020

View reviewed changes

garymathews added the in-qe-testing 🕵 label Jul 8, 2020

ssjsamir self-requested a review July 9, 2020 14:47

ssjsamir approved these changes Jul 9, 2020

View reviewed changes

sgtcoolguy closed this Jul 13, 2020

jquick-axway mentioned this pull request Mar 9, 2021

fix(android): support transparent backgrounds with touchFeedback #12446

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(android): support touch feedback for all backgrounds or no background #11795

feat(android): support touch feedback for all backgrounds or no background #11795

jquick-axway commented Jun 24, 2020 •

edited

build commented Jun 24, 2020 •

edited

sgtcoolguy Jun 25, 2020

jquick-axway Jun 25, 2020

sgtcoolguy Jul 13, 2020 •

edited

sgtcoolguy Jun 25, 2020

jquick-axway Jun 25, 2020

sgtcoolguy left a comment

ssjsamir left a comment

sgtcoolguy commented Jul 13, 2020

feat(android): support touch feedback for all backgrounds or no background #11795

feat(android): support touch feedback for all backgrounds or no background #11795

Conversation

jquick-axway commented Jun 24, 2020 • edited

build commented Jun 24, 2020 • edited

sgtcoolguy Jun 25, 2020

Choose a reason for hiding this comment

jquick-axway Jun 25, 2020

Choose a reason for hiding this comment

sgtcoolguy Jul 13, 2020 • edited

Choose a reason for hiding this comment

sgtcoolguy Jun 25, 2020

Choose a reason for hiding this comment

jquick-axway Jun 25, 2020

Choose a reason for hiding this comment

sgtcoolguy left a comment

Choose a reason for hiding this comment

ssjsamir left a comment

Choose a reason for hiding this comment

sgtcoolguy commented Jul 13, 2020

jquick-axway commented Jun 24, 2020 •

edited

build commented Jun 24, 2020 •

edited

sgtcoolguy Jul 13, 2020 •

edited