New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): implement borderRadius corner support #11796
Conversation
1041457
to
b03a85a
Compare
b03a85a
to
4971370
Compare
Tests:
|
4971370
to
b902749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM. Ideally we'd have an actual UI test for this, but that requires us to merge #11699 and get the view comparisons code in the test suite first.
Only change I see is the API doc mismatch (expecting Dictionary
instead of Array
)
So this is approved with the caveat that the API doc change needs to be fixed before merge.
Co-authored-by: Christopher Williams <chris.a.williams@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed Tested with the test case above, able to see borderRadius corner
change the border radius control also tested with different value e.g.
const view_a = Ti.UI.createView({
backgroundColor: 'red',
width: 100,
height: 50,
top: 100,
borderRadius: '20 20px 20 30'
});
const view_b = Ti.UI.createView({
backgroundColor: 'blue',
width: 100,
height: 50,
top: 150,
borderRadius: [ '20', '30px', '40dp', 20 ]
});
Test Environment
MacOS Big Sur: 11.0 Beta
Xcode: 12.0 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.0.0""
API29 Pixel XL emulator
I'll combine this with #11801 and add a few more tests/UI snapshot tests... |
manually merged into master (after fixing bug with applying 2 value use case against wrong corners) |
Fix verified on build 9.1.0.v20200804082025. Test environment
|
View
cornersTEST CASE
JIRA Ticket