New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): update Ti.UI.View.borderRadius to accept number, array and string #11801
Conversation
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a super nit-picky note about variable usage, but nothing dramatic. Approved!
FR Passed Tested with the test case in https://jira.appcelerator.org/browse/TIMOB-27305?focusedCommentId=455767&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-455767, able to see
Test Environment
|
manually merged into master |
@Max87ZA - Can you post the code used to generate this (or a sample app)? |
Hi Brenton, I also wrote to JIRA ticket https://jira.appcelerator.org/browse/TIMOB-27305, working on standalone app Edit: @brentonhouse here it is. In app/lib folder there is chart.js where is the code to generate that chart. |
Thanks @Max87ZA! |
Fix verified on build 9.1.0.v20200804082025. Test environment
|
https://jira.appcelerator.org/browse/TIMOB-27305
Note - Merge with PR #11796 , which have doc changes. Unit test is copied from there.