fix(ios): report width/height of Blob as pixels, not points #11803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some sizes and scales, it is impossible to reconstruct the true number of pixels in JS just with screen density/scale. We need to multiple image scale vs pts natively. i.e. 10px square iumage on a 3x device reported width/height of 3, device scale of 3. Multiplying in JS naively we'd get image size of 9px x 9px, which was incorrect. Fixes TIMOB-27997
|
janvennemann
approved these changes
Jul 8, 2020
ssjsamir
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
FR Passed: Width/Height now returns the expected values, tested using the test case below.
Test case:
win = Ti.UI.createWindow();
const view = Ti.UI.createView({
backgroundColor: 'green',
width: '11px',
height: '13px'
});
win.add(view);
win.addEventListener('postlayout', function postlayout() {
win.removeEventListener('postlayout', postlayout);
const blob = view.toImage();
console.log('Value should = 11, Value = ' + blob.width);
console.log('Value should = 13, Value = ' + blob.height);
});
win.open();
Result:
[INFO] �� � Value should = 11, Value = 11
[INFO] �� � Value should = 13, Value = 13
Test Environment
MacOS Big Sur: 11.0 Beta
Xcode: 12.0 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.0.0""
iphone 8 Sim (14.0 Beta)
|
Fix verified on build 9.1.0.v20200804082025. Test environment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27997
Optional Description:
With some sizes and scales, it is impossible to reconstruct the true number of pixels
in JS just with screen density/scale. We need to multiple image scale vs pts natively.
i.e. 10px square image on a 3x device reported width/height of 3, device scale of 3.
Multiplying in JS naively we'd get image size of 9px x 9px, which was incorrect.
Found when an image comparison test failed on #11699 which was the result of using a 10px x 10px view/image on a 3x simulator. (I knew about the points vs pixels issue, but had to work around it by forcing the view to use a multiple of 3 for it's size, since
blob.width * Ti.Platform.displayCaps.logicalDensityFactorgave us9)