Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): Ti.Locale.parseDecimal() whitespace separator handling #11824

Merged
merged 2 commits into from Jul 16, 2020
Merged

fix(ios): Ti.Locale.parseDecimal() whitespace separator handling #11824

merged 2 commits into from Jul 16, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27874

Summary:

  • If locale uses a whitespace char for a number's thousands/group separator (like French), then all whitespace char types should be handled.
  • For French locale, iOS 13 defaults to \u202F and older iOS versions default to \u00A0.
  • Was causing a unit test failure on iOS 13.

@jquick-axway
fix(ios): parseDecimal() whitespace thousands sep handling
48f7fdf 
- For locales using whitespace for thousands/group separators (such as French), all whitespace character types should be accepted.

Fixes TIMOB-27874
@jquick-axway jquick-axway added this to the 9.1.0 milestone Jul 15, 2020
@build build requested a review from a team July 15, 2020 23:06
@build
Copy link
Contributor

build commented Jul 15, 2020 •
edited

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️

Commit 48f7fdf46ad1b80abec93aeb6d2ff15c211801c4 has a message "fix(ios): parseDecimal() whitespace thousands sep handling

  • For locales using whitespace for thousands/group separators (such as French), all whitespace character types should be accepted.

Fixes TIMOB-27874" giving 1 errors:

  • body's lines must not be longer than 100 characters
Messages
📖

💾 Here's the generated SDK zipfile.
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖 ❌ 4 tests have failed There are 4 tests failing and 700 skipped out of 7502 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.fs#truncate() truncates to 0 bytes by default (13.3)0.005
Error: expected Error {
  line: 13207,
  column: 25,
  sourceURL: 'file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.main.js',
  message: 'Offset 0 is past buffer bounds (length 0)'
} to not exist
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/fs.test.js:1042:17
finish@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.main.js:13133:15
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.main.js:13613:15
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.main.js:13207:15
[native code]
writeTiFileStream@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.main.js:13205:18
writeString@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.main.js:13611:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.main.js:13230:16
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.main.js:13154:15
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.main.js:12404:13
ios.ipad.Titanium.Database#executeAll() throws Error for invalid SQL statement (13.3)0.003
Error: expected undefined to exist
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti.database.test.js:560:64
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3092E1B-86D7-4525-83BF-31A47879CA0A/data/Containers/Bundle/Application/FAA46A38-A69B-41F7-9FE5-D358258F9825/mocha.app/ti-mocha.js:5764:23
ios.iphone.fs#truncate() truncates to 0 bytes by default (13.5)0.004
Error: expected Error { message: 'Offset 0 is past buffer bounds (length 0)' } to not exist
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/fs.test.js:1042:17
finish@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti.main.js:13133:15
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti.main.js:13613:15
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti.main.js:13207:15
[native code]
writeTiFileStream@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti.main.js:13205:18
writeString@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti.main.js:13611:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti.main.js:13230:16
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti.main.js:13154:15
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti.main.js:12404:13
ios.iphone.Titanium.Database#executeAll() throws Error for invalid SQL statement (13.5)0.002
Error: expected undefined to exist
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti.database.test.js:560:64
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/A3F529A0-4FDC-4D95-A961-935C4316AB20/data/Containers/Bundle/Application/E20DCA81-C2C3-4F4D-8BF3-C7F4D715E175/mocha.app/ti-mocha.js:5764:23

Generated by 🚫 dangerJS against e3bb590

@jquick-axway jquick-axway mentioned this pull request Jul 16, 2020
Merged
@sgtcoolguy sgtcoolguy merged commit d5e0503 into tidev:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug ios no tests
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jquick-axway @build @sgtcoolguy