fix: fix crashing Ti.Platform.openURL #11826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logdanger-results://tmp/danger-results.json |
|
Fixed in 31424c6 (and cherry-picked to 9_1_X and 9_3_X) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27846
This is a severe regression from the SDK 9 changes related to the refactoring of several core module like "Ti.Platform" and "Ti.Geolocation".
JSValuehere are never nil (in this case, by default they are "JS-undefined"). It can probably also have caused other regressions, so please check on those as well. An example test case is added in JIRA, which could be added to the test suite, if it doesn't cause trouble for other test cases because the app is backgrounded.