Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(9_1_X): Intl formatToParts() on Android 4.4 #11831

Closed

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 9.1.0 milestone Jul 21, 2020
@build build requested a review from a team July 21, 2020 03:20
@build
Copy link
Contributor

build commented Jul 21, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 7 tests have failed There are 7 tests failing and 701 skipped out of 7608 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.ImageViewimage error event (13.5)5.002
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:53732
ios.ipad.Titanium.UI.Shortcut#add() add a single shortcut item (13.5)0.001
Error: expected 1 to equal 2
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti.ui.shortcut.test.js:140:34
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:5764:23
ios.ipad.Titanium.UI.Shortcut#remove() removes single shortcut item (13.5)0.001
Error: expected 1 to equal 2
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti.ui.shortcut.test.js:112:34
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:5764:23
ios.ipad.Titanium.UI.Shortcut#removeAll() removes shortcut items (13.5)0.001
Error: expected 1 to equal 2
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti.ui.shortcut.test.js:85:34
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/006BBAD6-FE3A-4961-812E-4C7EB214F297/data/Containers/Bundle/Application/CC993E50-E146-4B81-96B3-DEC34A63998B/mocha.app/ti-mocha.js:5764:23
ios.iphone.Titanium.UI.Shortcut#add() add a single shortcut item (13.3)0.002
Error: expected 1 to equal 2
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti.ui.shortcut.test.js:140:34
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:5764:23
ios.iphone.Titanium.UI.Shortcut#remove() removes single shortcut item (13.3)0.002
Error: expected 1 to equal 2
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti.ui.shortcut.test.js:112:34
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:5764:23
ios.iphone.Titanium.UI.Shortcut#removeAll() removes shortcut items (13.3)0.003
Error: expected 1 to equal 2
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti.ui.shortcut.test.js:85:34
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/C2325009-2EA7-417A-B574-40D09A9F02EC/data/Containers/Bundle/Application/306DE916-C901-47FA-AA85-7E92AA88521D/mocha.app/ti-mocha.js:5764:23

Generated by 🚫 dangerJS against 0982839

@sgtcoolguy
Copy link
Contributor

Manually cherry-picked to 9_1_X and 9_3_X.

@sgtcoolguy sgtcoolguy closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants